fix(attributes): Loading when clearing group by or visualize#112364
Open
nsdeschenes wants to merge 3 commits intomasterfrom
Open
fix(attributes): Loading when clearing group by or visualize#112364nsdeschenes wants to merge 3 commits intomasterfrom
nsdeschenes wants to merge 3 commits intomasterfrom
Conversation
Keep previous attribute results in place while the dropdown refetches a server-filtered search, but only show loading for the initial load and active non-empty search requests. This keeps clear-to-empty transitions from flashing a misleading loading state. Refs EXP-797 Co-Authored-By: GPT-5.4 <noreply@openai.com> Made-with: Cursor
Add hook coverage for default, searched, and cleared attribute searches so we keep server-side substring filtering while preserving the intended loading signal across transitions. Refs EXP-797 Co-Authored-By: GPT-5.4 <noreply@openai.com> Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 13bbc3f. Configure here.
Only report attribute loading while a query is actively fetching so disabled queries do not stay stuck in a pending spinner state. Add a regression test for the TanStack Query v5 disabled-query case. Co-Authored-By: GPT-5.4 <noreply@openai.com> Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue with the group by dropdown, visualize dropdown, and schema hint list. Since all three of these components use the same data fetching hook under the hood, when clearing the search entry in the dropdowns it would trigger a refetch and thus trigger the schema hint list to be put into a loading state.
This PR resolves this issue by utilizing the built in
keepPreviousDatahelper, and tweaking how we determine whatisFetchingis resolved to, so that we only show the loading indicator on-load for the schema hint list, and only on the dropdowns when searching.Closes EXP-797